Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why not hard fork an existing library? #35

Closed
0xSalman opened this issue Feb 27, 2018 · 1 comment
Closed

Question: Why not hard fork an existing library? #35

0xSalman opened this issue Feb 27, 2018 · 1 comment

Comments

@0xSalman
Copy link

0xSalman commented Feb 27, 2018

Hey,

Thank you for your great work; this library has a lot of potential. Sorry, I am not sure where else to ask this question. I am curious to know why did you decide to create a new library. Why not just hard fork neelance's go library?

At my work, we are using neelance's go library and even wrote our own code generator. We are also looking at its internal code and has hard forked it to experiment changes (i.e., make internal code exportable, use fields as resolver instead of methods, access to requested fields, add missing security features etc)

@vektah
Copy link
Collaborator

vektah commented Feb 27, 2018

This is a hard fork of the neelance library, I've reused the parsers and validation but code generated the execution environment.

I hope that graph-gophers/graphql-go#116 gets resolved and we can start collaborating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants