Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocoto breaks with the upcoming Guice 4.0 release (currently in beta) #7

Open
ntolia opened this issue Aug 4, 2013 · 2 comments
Open

Comments

@ntolia
Copy link

ntolia commented Aug 4, 2013

Guice 4.0 is currently in beta - https://code.google.com/p/google-guice/wiki/Guice40. As stated in the wiki page:

Many things inside com.google.inject.internal changed and/or moved. This is especially true for repackaged Guava (formerly Google Collections)

This impacts rocoto because it will not find Guice-internal Preconditions:

java.lang.NoClassDefFoundError: com/google/inject/internal/util/$Preconditions

I am wondering if it makes sense to include a direct dependency on Guava. Reworking imports will break compatibility with at least Guice 3.0.

@benmccann
Copy link
Contributor

Yes, this should be fixed. I upgraded to Guice 4.0 today and my project broke. It's a horrible idea to depend on internal Guice classes. See #8

@benmccann
Copy link
Contributor

I think this should be fixed with 17ae116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants