-
Notifications
You must be signed in to change notification settings - Fork 148
Conversation
Dynamically inserts references to the model.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 5 +1
Lines 247 276 +29
Branches 31 37 +6
=====================================
+ Hits 247 276 +29
Continue to review full report at Codecov.
|
Awesome! |
Any idea on when this might be released? |
@ShaunEgan I wanted to do something for this on the weekend. There is another ticket I want to include into |
Great, thanks |
So this doesn't work when doing validation using |
I don't have experience with ajv, but I looked at its docs quickly. It does support $ref, which is part of the standard, but I can see why it would get confused by the unprocessed references. I can't really think of a great solution. We could change this feature so that instead of $ref we use a different keyword ('awsref'?), and then at least things which are expecting a real reference won't get confused. But I don't think that really solves your problem, which is that you want to do validation using composition of the unprocessed model definitions. I think you're going to have to pick one way of doing it or the other. I am holding out hope that AWS adds support for enabling validation via CloudFormation soon. |
Could you please publish a new version on npm? |
Yes, will do this today |
@vilius-rugaitis Released with version 1.0 :) |
@vilius-rugaitis Oh, my bad. thought this package had an automated publishing process in travis ci. |
Dynamically inserts references to the model.