Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving Character to Database #141

Closed

Conversation

LtRipley36706
Copy link
Member

@LtRipley36706 LtRipley36706 commented Mar 18, 2017

"Ripley has been saved."

This PR includes commits from the following PRs:
#117
#119
#125
#134

This PR addresses issues:
#51
#52
#53

Code work was done by @fantoms and myself

Accepting this PR should mean closing without merging the previously mentioned PRs and mostly resolves the issues.

Spending Skill Credits is not yet addressed.

fantoms and others added 21 commits March 16, 2017 00:39
Characters now level up behind the scenes

Gave the ability to level up with effects and message

Added Network Message Type for Ints

Removed debugging and updated comments

Added GameMessagePrivateUpdatePropertyInt

Allow for max level and lock

Changed to a long to allow greater amounts of XP
Added level up skill credit text and max level

Added skill credits and comments

Removed my comments and started using queries to get data from the chart
Fixed up the grantxp command. Now limited to 999,999,999,999.

Fixed the one-line if statement causing headaches; please test!

Added final level effect, moved effect after the network message to perhaps prevent an order issue.

Now limits the grantxp ammount, until you're max level.

Added a way to add xp after max level

Now locks total xp properperly on max level
Removed a debug test

Unset networktrace

Readded a line
* reverted unintentional changes
* object factories, log4net, and various refactorings.  still getting stuck in portal space occasionally.
* rebased with latest changes, add removal of players from landblocks upon logout (i think)
…birth. Set up aging for character and updating to client.
LtRipley36706 and others added 24 commits March 18, 2017 14:41
Landblocks, logging, object factory prep work
Characters now level up behind the scenes

Gave the ability to level up with effects and message

Added Network Message Type for Ints

Removed debugging and updated comments

Added GameMessagePrivateUpdatePropertyInt

Allow for max level and lock

Changed to a long to allow greater amounts of XP
Added level up skill credit text and max level

Added skill credits and comments

Removed my comments and started using queries to get data from the chart
Fixed up the grantxp command. Now limited to 999,999,999,999.

Fixed the one-line if statement causing headaches; please test!

Added final level effect, moved effect after the network message to perhaps prevent an order issue.

Now limits the grantxp ammount, until you're max level.

Added a way to add xp after max level

Now locks total xp properperly on max level
Removed a debug test

Unset networktrace

Readded a line
…birth. Set up aging for character and updating to client.
…36706/ACE.git

Conflicts:
	Source/ACE.Database/CharacterDatabase.cs
	Source/ACE/Managers/GuidManager.cs
	Source/ACE/Network/Session.cs
@LtRipley36706
Copy link
Member Author

I broke this PR in an attempt to rebase off of current master.. My git-fu needs improvement.

@LtRipley36706 LtRipley36706 deleted the feature-SavingCharacter branch March 20, 2017 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants