-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving Character to Database #141
Closed
LtRipley36706
wants to merge
51
commits into
ACEmulator:master
from
LtRipley36706:feature-SavingCharacter
Closed
Saving Character to Database #141
LtRipley36706
wants to merge
51
commits into
ACEmulator:master
from
LtRipley36706:feature-SavingCharacter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Characters now level up behind the scenes Gave the ability to level up with effects and message Added Network Message Type for Ints Removed debugging and updated comments Added GameMessagePrivateUpdatePropertyInt Allow for max level and lock Changed to a long to allow greater amounts of XP
Added level up skill credit text and max level Added skill credits and comments Removed my comments and started using queries to get data from the chart
Fixed up the grantxp command. Now limited to 999,999,999,999. Fixed the one-line if statement causing headaches; please test! Added final level effect, moved effect after the network message to perhaps prevent an order issue. Now limits the grantxp ammount, until you're max level. Added a way to add xp after max level Now locks total xp properperly on max level
Removed a debug test Unset networktrace Readded a line
* reverted unintentional changes * object factories, log4net, and various refactorings. still getting stuck in portal space occasionally. * rebased with latest changes, add removal of players from landblocks upon logout (i think)
…ic bug fix in Landblock.
This was referenced Mar 18, 2017
Landblocks, logging, object factory prep work
Characters now level up behind the scenes Gave the ability to level up with effects and message Added Network Message Type for Ints Removed debugging and updated comments Added GameMessagePrivateUpdatePropertyInt Allow for max level and lock Changed to a long to allow greater amounts of XP
Added level up skill credit text and max level Added skill credits and comments Removed my comments and started using queries to get data from the chart
Fixed up the grantxp command. Now limited to 999,999,999,999. Fixed the one-line if statement causing headaches; please test! Added final level effect, moved effect after the network message to perhaps prevent an order issue. Now limits the grantxp ammount, until you're max level. Added a way to add xp after max level Now locks total xp properperly on max level
Removed a debug test Unset networktrace Readded a line
…36706/ACE.git Conflicts: Source/ACE.Database/CharacterDatabase.cs Source/ACE/Managers/GuidManager.cs Source/ACE/Network/Session.cs
I broke this PR in an attempt to rebase off of current master.. My git-fu needs improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Ripley has been saved."
This PR includes commits from the following PRs:
#117
#119
#125
#134
This PR addresses issues:
#51
#52
#53
Code work was done by @fantoms and myself
Accepting this PR should mean closing without merging the previously mentioned PRs and mostly resolves the issues.
Spending Skill Credits is not yet addressed.