Saving Character to Database #143

LtRipley36706 · 2017-03-18T19:35:31Z

"Ripley has been saved."

This PR includes commits from the following PRs:
#117
#119
#125
#134
#141

This PR addresses issues:
#51
#52
#53

Code work was done by @fantoms and myself

Accepting this PR should mean closing without merging the previously mentioned PRs and mostly resolves the issues.

Spending Skill Credits is not yet addressed.

Characters now level up behind the scenes Gave the ability to level up with effects and message Added Network Message Type for Ints Removed debugging and updated comments Added GameMessagePrivateUpdatePropertyInt Allow for max level and lock Changed to a long to allow greater amounts of XP

Added level up skill credit text and max level Added skill credits and comments Removed my comments and started using queries to get data from the chart

Fixed up the grantxp command. Now limited to 999,999,999,999. Fixed the one-line if statement causing headaches; please test! Added final level effect, moved effect after the network message to perhaps prevent an order issue. Now limits the grantxp ammount, until you're max level. Added a way to add xp after max level Now locks total xp properperly on max level

Removed a debug test Unset networktrace Readded a line

…birth

…birth. Set up aging for character and updating to client.

@fantoms

…ation, thanks @fantoms !

Mogwai-TheFurry

If you could get these things fixed soon, that'd be great. If not, let me know and we can get them merged as is and you can update it with the changes later.

Mogwai-TheFurry · 2017-03-20T01:52:05Z

Source/ACE.Database/CharacterDatabase.cs

@@ -151,12 +171,18 @@ public bool IsNameAvailable(string name)
            return (charsWithName == 0);
        }

-        public Task UpdateCharacter(Character character)
+        public async void UpdateCharacter(Character character)


Thou shalt not async void.

Mogwai-TheFurry · 2017-03-20T01:54:48Z

Source/ACE.Database/Database.cs

                                    command.Parameters.Add("", query.Item1.Types[i]).Value = query.Item2[i];
-
+#if NETWORKDEBUG


use log4net instead, please.

Mogwai-TheFurry · 2017-03-20T01:57:56Z

Source/ACE/Command/Handlers/DebugCommands.cs

+
+                message = $"Unable to find a effect called {parameters[0]} to play.";
+
+                if (Enum.TryParse(parameters[0], true, out effect))


on non-1-liner "if" statements, we really need to use explicit "{" and "}" stuff. took me a while to visually parse this.

Mogwai-TheFurry · 2017-03-20T01:58:33Z

Source/ACE/Command/Handlers/DebugCommands.cs

-                //ex...more info.. if needed..
-                ChatPacket.SendServerMessage(session, $"Invalid Effect value", ChatMessageType.Broadcast);
-                return;
+                //ChatPacket.SendServerMessage(session, parameters[0], ChatMessageType.Broadcast);


need to do something in the catch, even if it's a comment that it's intentionally blank/empty.

Mogwai-TheFurry · 2017-03-20T02:04:36Z

Source/ACE/Entity/Player.cs

-            var effectevent = new GameMessageEffect(this.Guid, effectid);
-            Session.Network.EnqueueSend(effectevent);
+            var effectEvent = new GameMessageEffect(this.Guid, effectId);
+            Session.Network.EnqueueSend(effectEvent);
        }

        /// <summary>


In SpendSkillXp below, you're not taking usage-earned xp into account:
uint currentXp = chart.Ranks[Convert.ToInt32(skill.Ranks)].TotalXp;

You don't need to fix it, but you need to document it in a TODO or a known issue.

Mogwai-TheFurry · 2017-03-20T02:06:11Z

Source/ACE/Entity/Player.cs

+            }
+            catch (NullReferenceException)
+            {
+


either comment why this is empty, handle the exception, or remove the catch.

Mogwai-TheFurry · 2017-03-20T02:06:15Z

Source/ACE/Entity/Player.cs

+            }
+            catch (NullReferenceException)
+            {
+


either comment why this is empty, handle the exception, or remove the catch.

Mogwai-TheFurry · 2017-03-20T02:07:05Z

Source/ACE/Entity/Player.cs

@@ -728,9 +894,9 @@ public void Logout(bool clientSessionTerminatedAbruptly = false)

            // NOTE: Adding this here for now because some chracter options do not trigger the GameActionSetCharacterOptions packet to fire when apply is clicked (which is where we are currently saving to the db).
            // Once we get a CharacterSave method, we might consider removing this and putting it in that method instead.
-            DatabaseManager.Character.SaveCharacterOptions(character);
+            //DatabaseManager.Character.SaveCharacterOptions(character);


You commented this out, but why? If it's implemented elsewhere, just delete it. if not, it'd be good to know why this is no longer needed.

Mogwai-TheFurry · 2017-03-20T02:09:10Z

Source/ACE/Network/GameAction/Actions/GameActionTeleToMarketplace.cs

+
+        public override void Handle()
+        {
+            Position marketplaceDrop = new Position(23855548, 49.16f, -31.62f, 0.10f, 0f, 0f, -0.71f, 0.71f); // Is this the right drop?


convert this into a static readonly position object, please. no need to allocate a new one every time - it just creates work for the garbage collector.

fantoms and others added 20 commits March 18, 2017 15:16

Added available skill credits

b9cb0c9

Added level up skill credit text and max level Added skill credits and comments Removed my comments and started using queries to get data from the chart

Updated for Network and removed the xp text after reaching max level

b0fcf69

Added attribute upper bounds check, fireworks, and special text

9e791d4

Removed a debug test Unset networktrace Readded a line

Merged in network changes

5fceb6c

Merged in network changes 2

79eb13a

Added Attribute and Skill saving to character db. Wired up @Age and @…

75b41ac

…birth. Set up aging for character and updating to client.

Adding @mp command and merging in changes need to match current master

2692dd5

Cleaning up code

fd15629

More code cleaning.

aae12c5

Added TotalSkillCredits increment for eventual skill resets.

78d0308

Code Style change

8208064

Fixing a crash stemming from when you spend to many points in coordin…

e2f64e6

…ation, thanks @fantoms !

Better saving on logout and crashes.

47fb388

Minor Tweaks

86575cd

More changes to character stats db to account for high level stats

c3fcf26

Code style application.

4c509f7

Renamed a sql file to better reflect what it did.

d9ebb71

Code Style change

cb3f2af

fantoms mentioned this pull request Mar 19, 2017

Skill Credits: saving, loading, spending #53

Closed

Mogwai-TheFurry suggested changes Mar 20, 2017

View reviewed changes

Mogwai-TheFurry added the blocked:Needs rework label Mar 20, 2017

PR requested changes

d56c69d

Mogwai-TheFurry removed the blocked:Needs rework label Mar 20, 2017

Mogwai-TheFurry merged commit 15fab43 into ACEmulator:master Mar 20, 2017

LtRipley36706 deleted the feature-SavingCharacter-v2 branch March 20, 2017 02:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Saving Character to Database #143

Saving Character to Database #143

LtRipley36706 commented Mar 18, 2017

Mogwai-TheFurry left a comment

Mogwai-TheFurry Mar 20, 2017

Mogwai-TheFurry Mar 20, 2017

Mogwai-TheFurry Mar 20, 2017

Mogwai-TheFurry Mar 20, 2017

Mogwai-TheFurry Mar 20, 2017

Mogwai-TheFurry Mar 20, 2017

Mogwai-TheFurry Mar 20, 2017

Mogwai-TheFurry Mar 20, 2017

Mogwai-TheFurry Mar 20, 2017

		command.Parameters.Add("", query.Item1.Types[i]).Value = query.Item2[i];

		#if NETWORKDEBUG


		message = $"Unable to find a effect called {parameters[0]} to play.";

		if (Enum.TryParse(parameters[0], true, out effect))

Saving Character to Database #143

Saving Character to Database #143

Conversation

LtRipley36706 commented Mar 18, 2017

Mogwai-TheFurry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment