Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add god admin command #1924

Merged
merged 7 commits into from
Jun 9, 2019
Merged

add god admin command #1924

merged 7 commits into from
Jun 9, 2019

Conversation

dirtyelf
Copy link
Contributor

@dirtyelf dirtyelf commented May 21, 2019

add /god admin command functionality

  • sets level to 999
  • specializes every skill
  • sets attributes to 9999
  • level up and BZ particle effects

Copy link
Member

@LtRipley36706 LtRipley36706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall probably minimal impact, but this implementation deviates from what I recall the real command doing.

Aside from the flourishes at the end of it, the only concerning part is the training/specing of every skill including ones that were depreciated, and possible desync on crash maybe

I won't have time to play test this for a few more days however

@dirtyelf
Copy link
Contributor Author

any idea what the retail command did specifically?

@LtRipley36706
Copy link
Member

any idea what the retail command did specifically?

from what I remember it just set whatever currently spec/trained skills to a specific level (not sure what), and i think changed the level to match that same number...

it's probably not that big of a deal being an admin only function

@dirtyelf
Copy link
Contributor Author

dirtyelf commented Jun 8, 2019

this is definitely more fun, and serves the same purpose.

i can not figure out why i need two calls to setmaxvitals() to get the hp to update in the client. it was working back when i was first looking at this, now it needs the second call. stam and mana seem to update just fine with the first call. also it appears to only be the client, calling /showstats reports the correct values in the terminal for health - just not in the client.

ultimately not a huge deal, just leave the second call to setmaxvitals in there... but it may be something that affects other areas so worth noting

@gmriggs gmriggs merged commit 9869c6d into ACEmulator:master Jun 9, 2019
@dirtyelf dirtyelf deleted the godmode branch June 9, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants