Add busy checks for recall/PKL commands #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…animation, e.g. entering PKL, going to MP/HOM/AH/LS
…mands during emotes. Added same checks to house recall and lifestone recall
|
So... for some reason I've noticed that I don't get the "You're too busy" weenie error, but it does work in terms of preventing the concurrent recall/pkl commands. Any idea as to why? |
|
There is already precedent set for checking 'if (IsBusy || Teleporting)' throughout the existing code-base that I don't think a new getter to encapsulate this check is really necessary. |
Just tested, I get the "You're too busy!" error |
gmriggs
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it is possible to use multiple recall commands as well as the PKL command simultaneously. You can test on the master branch by typing /mp and then immediately typing /pkl. You will notice that you become PKL just before you teleport to marketplace. You can use these commands while teleporting in portal space which will begin the timer for the action concurrently with the current teleport/action.
This PR adds a common check to determine whether a recall (or entering PKL) is possible at that time. It checks for whether the character is busy or is already teleporting.