Fix: Mana on XP Spend #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed the @HEAL command from raising the wrong attribute and getting the client out of wack
|
This pr was created to address issue #296. To address the mana updates, a mana update message is now sent when self is updated. After changing the |
| @@ -1025,9 +1025,9 @@ public static void HandleHeal(Session session, params string[] parameters) | |||
| session.Player.Stamina.Current = session.Player.Stamina.UnbuffedValue; | |||
| session.Player.Mana.Current = session.Player.Mana.UnbuffedValue; | |||
|
|
|||
| var updatePlayersHealth = new GameMessagePrivateUpdateAttribute2ndLevel(session, Vital.Health, session.Player.Health.Current); | |||
| var updatePlayersStamina = new GameMessagePrivateUpdateAttribute2ndLevel(session, Vital.Stamina, session.Player.Stamina.Current); | |||
| var updatePlayersMana = new GameMessagePrivateUpdateAttribute2ndLevel(session, Vital.Mana, session.Player.Mana.Current); | |||
There was a problem hiding this comment.
GameMessagePrivateUpdateAttribute2ndLevel is the right message for what this command is doing, I think you've found an error with how we're handling the sequence for this message however.
3 different numbers in a row based on this retail pcap...
LtRipley36706
requested changes
May 3, 2017
…ences will be investigated next.
fantoms
changed the title
@heal command change
Mogwai-TheFurry
added a commit
that referenced
this pull request
May 4, 2017
This reverts commit 7109c90.
Mogwai-TheFurry
added a commit
that referenced
this pull request
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manapoints after spending experience points onSelf.@healcommand may prevent vitals increasing.