Add RPC to bump local commit fees #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node operators may disable automatic fee-bumping on their local commit if they don't have anything at stake (no pending HTLCs), which saves fees in most cases. A drawback in that case is that if the commitment doesn't confirm quickly enough, the remote's funds are also locked. This can be an issue for LSPs, where the remote peer doesn't have a good ability to fee-bump commit txs. We give more control to the node operator by letting them fee-bump local commit txs explicitly through the RPC to unblock wallet users funds.
t-bast
force-pushed
the
bump-commit-rpc
branch
from
7d24d72
to
a012277
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2743 +/- ##
==========================================
+ Coverage 85.87% 85.88% +0.01%
==========================================
Files 215 215
Lines 17833 17854 +21
Branches 775 756 -19
==========================================
+ Hits 15314 15334 +20
- Misses 2519 2520 +1
|
pm47
approved these changes
Sep 14, 2023
t-bast
added a commit
that referenced
this pull request
Feb 29, 2024
This release introduces a few API changes: - `bumpforceclose` can be used to make a force-close confirm faster, by spending the anchor output (#2743) - `open` now takes an optional parameter `--fundingFeeBudgetSatoshis` to define the maximum acceptable value for the mining fee of the funding transaction. This mining fee can sometimes be unexpectedly high depending on available UTXOs in the wallet (#2808) - `rbfopen` now takes a mandatory parameter `--fundingFeeBudgetSatoshis` with the same semantics as for `open` (#2808) - `payoffer` can be used to pay experimental Bolt 12 offers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node operators may disable automatic fee-bumping on their local commit if they don't have anything at stake (no pending HTLCs), which saves fees in most cases. A drawback in that case is that if the commitment doesn't confirm quickly enough, the remote's funds are also locked.
This can be an issue for LSPs, where the remote peer doesn't have a good ability to fee-bump commit txs. We give more control to the node operator by letting them fee-bump local commit txs explicitly through the RPC to unblock wallet users funds.