Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More metrics #1196

Merged
merged 2 commits into from
Nov 4, 2019
Merged

More metrics #1196

merged 2 commits into from
Nov 4, 2019

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Oct 30, 2019

This adds metrics on bitcoin rpc calls and on scodec.

@pm47 pm47 requested a review from sstone October 30, 2019 15:03
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #1196 into master will decrease coverage by 8.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
- Coverage   84.06%   75.45%   -8.62%     
==========================================
  Files         104      135      +31     
  Lines        7928     9076    +1148     
  Branches      345      352       +7     
==========================================
+ Hits         6665     6848     +183     
- Misses       1263     2228     +965
Impacted Files Coverage Δ
.../fr/acinq/eclair/wire/LightningMessageCodecs.scala 100% <100%> (ø) ⬆️
...in/bitcoind/rpc/BatchingBitcoinJsonRPCClient.scala 100% <100%> (ø) ⬆️
...ore/src/main/scala/fr/acinq/eclair/PimpKamon.scala 100% <100%> (+100%) ⬆️
...chain/bitcoind/rpc/BasicBitcoinJsonRPCClient.scala 100% <100%> (ø) ⬆️
.../main/scala/fr/acinq/eclair/io/Authenticator.scala 92.59% <100%> (ø) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 75.44% <100%> (-0.3%) ⬇️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 96.22% <100%> (+0.07%) ⬆️
...in/scala/fr/acinq/eclair/wire/FailureMessage.scala 79.1% <100%> (ø) ⬆️
.../fr/acinq/eclair/gui/stages/OpenChannelStage.scala 0% <0%> (ø)
... and 32 more

@pm47 pm47 merged commit 5a6b791 into master Nov 4, 2019
@pm47 pm47 deleted the more-metrics branch November 4, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants