Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel sends typed responses #1321

Merged
merged 4 commits into from
Feb 25, 2020
Merged

Channel sends typed responses #1321

merged 4 commits into from
Feb 25, 2020

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Feb 12, 2020

Instead of sending strings, channel now sends typed responses.
This is more future-proof when we want to add data to those responses.

type-all-the-things

TODO:

  • E2E tests to verify nothing funky is happening.

@t-bast t-bast requested a review from pm47 February 12, 2020 17:13
@t-bast
Copy link
Member Author

t-bast commented Feb 12, 2020

Looks like I have to do some json serialization magic to make it smooth in the CLI, will add that in a separate commit.

@t-bast t-bast requested a review from pm47 February 18, 2020 12:34
@pm47
Copy link
Member

pm47 commented Feb 24, 2020

Needs merge/rebase

Instead of sending strings, channel now sends typed responses.
This is more future-proof when we want to add data to those responses.
It looks better in the CLI and API.
@codecov-io
Copy link

Codecov Report

Merging #1321 into master will increase coverage by 0.02%.
The diff coverage is 61.9%.

@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
+ Coverage   77.59%   77.62%   +0.02%     
==========================================
  Files         144      144              
  Lines       10138    10141       +3     
  Branches      395      406      +11     
==========================================
+ Hits         7867     7872       +5     
+ Misses       2271     2269       -2
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/payment/Auditor.scala 95.45% <ø> (ø) ⬆️
...in/scala/fr/acinq/eclair/api/JsonSerializers.scala 95.45% <ø> (ø) ⬆️
...cala/fr/acinq/eclair/db/sqlite/SqliteAuditDb.scala 99.01% <ø> (ø) ⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala 86.13% <0%> (ø) ⬆️
...n/scala/fr/acinq/eclair/channel/ChannelTypes.scala 78.26% <0%> (-11.74%) ⬇️
...q/eclair/payment/receive/MultiPartPaymentFSM.scala 92.5% <0%> (ø) ⬆️
...cinq/eclair/payment/receive/MultiPartHandler.scala 94.56% <0%> (ø) ⬆️
...fr/acinq/eclair/payment/relay/ChannelRelayer.scala 95.06% <100%> (ø) ⬆️
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala 85.36% <100%> (ø) ⬆️
...r/acinq/eclair/payment/send/PaymentLifecycle.scala 92.8% <100%> (ø) ⬆️
... and 5 more

@t-bast t-bast merged commit bb930cd into master Feb 25, 2020
@t-bast t-bast deleted the channel-no-string branch February 25, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants