Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reconnect immediately if we keep getting disconnected #1371

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Apr 9, 2020

If our latest successful connection attempt was less
than 30 seconds ago, we pick up the exponential
back-off retry delay where we left it. The
goal is to address cases where the reconnection
is successful, but we are disconnected right away.

If our latest successful connection attempt was less
than 30 seconds ago, we pick up the exponential
back-off retry delay where we left it. The
goal is to address cases where the reconnection
is successful, but we are disconnected right away.
@pm47 pm47 requested a review from t-bast April 9, 2020 14:40
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
It's not trivial to reason about this code, but reconnection back-off is inherently a bit hairy...

@pm47 pm47 merged commit 7a5dbfd into master Apr 10, 2020
@pm47 pm47 deleted the disconnect-loop branch April 10, 2020 11:05
@n1bor
Copy link
Contributor

n1bor commented Apr 14, 2020

fixes this one too #1205 - that was closed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants