-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gossip metrics #1372
Gossip metrics #1372
Conversation
Adding metrics for channel queries and gossip KPIs.
eclair-core/src/main/scala/fr/acinq/eclair/router/Monitoring.scala
Outdated
Show resolved
Hide resolved
|
||
object Monitoring { | ||
|
||
object Metrics { | ||
val FindRouteDuration = Kamon.timer("router.find-route.duration", "Path-finding duration") | ||
val RouteLength = Kamon.histogram("router.find-route.length", "Path-finding result length") | ||
|
||
val QueryChannelRangeBlocksCount = Kamon.histogram("router.gossip.query-channel-range.blocks-count", "Number of blocks requested in query-channel-range") | ||
val QueryChannelRangeRepliesCount = Kamon.histogram("router.gossip.query-channel-range.replies-count", "Number of reply-channel-range replies sent") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit strange that we have both QueryChannelRangeReplies*
and ReplyChannelRange*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to rename this one ReplyChannelRangeCount
? It kinda loses the information that it's the number of replies generated by a single incoming query, but as long as the comment here explains it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to not be helping much, I just feel that something is a bit awkward in the naming but have trouble coming up with something better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once inside a dedicated object, I think it's better. See 3e5a7b0
Adding metrics for channel queries and gossip KPIs.
@sstone @pm47 this is a good opportunity to add other metrics/logs if there are things that you wanted to have while you were investigating an issue and were missing. Please let me know if I can add other metrics related to gossip, or logs that may be useful for eclair-mobile/phoenix.
Don't hesitate to bikeshed the naming too if you don't like it, it will be a bit painful to change metric names once we have graphs/alerts we rely on.