Use the replyTo pattern for Register messages
#1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
changed the title
replyTo to Register messagesreplyTo pattern for Register messages
pm47
force-pushed
the
register-replyto
branch
2 times, most recently
from
51d06d7
to
d49e3a0
Compare
t-bast
reviewed
Sep 1, 2020
eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala
Outdated
Show resolved
Hide resolved
In preparation of the migration to typed actors, we need to remove the use of `sender`, which doesn't exist in typed actors (and even returns dead letters when mixing typed/untyped actors). This also means that, in the tests, we should stop using the `TestProbe.send()` method, which also relies on the recipient replying to `sender`. Instead, we should use `targetActor ! msg` which guarantees that the sender is void. Using the `replyTo` pattern doesn't mix well with the `ask` pattern, because we don't know the reference to the temporary actor. To deal with that, we set `replyTo = ActorRef.noSender` which is a bit hackish.
Co-authored-by: Bastien Teinturier <31281497+t-bast@users.noreply.github.com>
pm47
force-pushed
the
register-replyto
branch
from
6c7490d
to
d09ce0b
Compare
|
Rebased |
t-bast
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of the migration to typed actors, we need to remove the
use of
sender, which doesn't exist in typed actors (and even returnsdead letters when mixing typed/untyped actors).
This also means that, in the tests, we should stop using the
TestProbe.send()method, which also relies on the recipient replyingto
sender. Instead, we should usetargetActor ! msgwhich guaranteesthat the sender is void.
Using the
replyTopattern doesn't mix well with theaskpattern,because we don't know the reference to the temporary actor. To deal with
that, we set
replyTo = ActorRef.noSenderwhich is a bit hackish.NB: the akka doc shows the proper way of dealing with
askwith typed actors: