Truncate hex strings in front logs #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
previously approved these changes
Feb 1, 2021
Front-end logs can produce a huge amount of logs, with significant duplication. In order to reduce the log volume, we truncate `nodeId` and `channelId` in the MDC to only keep the first 8 hexadecimal characters. Also, override a few `toString` because some channel-queries-related case classes produce huge strings.
pm47
force-pushed
the
truncate-debug-logs
branch
from
b0c4611
to
86546a0
Compare
t-bast
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Front-end logs can produce a huge amount of logs, with significant
duplication. In order to reduce the log volume, we truncate
nodeIdandchannelIdin the MDC to only keep the first 8 hexadecimal characters.Also, override a few
toStringbecause some channel-queries-relatedcase classes produce huge strings.