Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding to blinded payment routes #2638

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

thomash-acinq
Copy link
Member

The lengths of the encrypted recipient data leak the base fees as they are encoded with a variable length, to compensate for that we always add padding.

The lengths of the encrypted recipient data leak the base fees as they are encoded with a variable length, to compensate for that we always add padding.
@codecov-commenter
Copy link

Codecov Report

Merging #2638 (97818a8) into master (71568ca) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
- Coverage   85.63%   85.62%   -0.02%     
==========================================
  Files         214      214              
  Lines       17537    17540       +3     
  Branches      758      730      -28     
==========================================
  Hits        15018    15018              
- Misses       2519     2522       +3     
Impacted Files Coverage Δ
.../fr/acinq/eclair/router/BlindedRouteCreation.scala 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thomash-acinq thomash-acinq merged commit 46149c7 into master Apr 14, 2023
@thomash-acinq thomash-acinq deleted the blinded-route-padding branch April 14, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants