Propagate next remote commit failed htlcs upstream #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When our peer fails HTLCs, we only propagate the failure upstream once we've received their revocation for the previous commitment (because they could otherwise publish the previous commitment and claim those HTLCs). If they publish the new commitment without sending us their revocation, we previously didn't propagate the failure upstream, which leads to an unnecessary force-close. We now correctly handle this scenario.
This is obsolete since the introduction of slow/medium/fast feerates.
pm47
approved these changes
Aug 16, 2023
|
Subtle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When our peer fails HTLCs, we only propagate the failure upstream once we've received their revocation for the previous commitment (because they could otherwise publish the previous commitment and claim those HTLCs).
If they publish the new commitment without sending us their revocation, we previously didn't propagate the failure upstream, which leads to an unnecessary force-close. We now correctly handle this scenario.
This issue was reported by @wtogami and is responsible for a force-close of one of our channels.