Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate next remote commit failed htlcs upstream #2718

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Propagate next remote commit failed htlcs upstream #2718

merged 2 commits into from
Aug 16, 2023

Commits on Jul 26, 2023

  1. Propagate next remote commit failed htlcs upstream 

    When our peer fails HTLCs, we only propagate the failure upstream once
we've received their revocation for the previous commitment (because they
could otherwise publish the previous commitment and claim those HTLCs).

If they publish the new commitment without sending us their revocation,
we previously didn't propagate the failure upstream, which leads to an
unnecessary force-close. We now correctly handle this scenario.
    @t-bast
    t-bast committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3c144e6 View commit details
    Browse the repository at this point in the history

  2. Remove unused on-chain-fee parameter 

    This is obsolete since the introduction of slow/medium/fast feerates.
    @t-bast
    t-bast committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    06f27b1 View commit details
    Browse the repository at this point in the history