Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we disconnect before receiving our peer's
tx_signatures
, we expect them to re-send it on reconnection (by filling thenext_funding_txid
field inchannel_reestablish
). In that case, our peer may also retransmit their correspondingcommit_sig
first (if they cannot be sure that we've received it). If we've already received thatcommit_sig
, we should ignore it. But we must make sure we don't end up ignoring othercommit_sig
messages!Eclair wasn't spec-compliant and wouldn't retransmit their
tx_signatures
if the transaction was already confirmed. We now store ourtx_signatures
even after confirmation or publication (if using 0-conf) to make sure we can retransmit them when requested.