Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tx_signatures retransmission #2748

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fix tx_signatures retransmission #2748

merged 3 commits into from
Sep 22, 2023

Commits on Sep 22, 2023

  1. Always retransmit tx_signatures if requested 

    If our peer asks us to retransmit our `tx_signatures`, we should do it even
if the transaction is already confirmed. That means we need to store our
`tx_signatures` because they're annoying to recompute.
    @t-bast
    t-bast committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    dc864ec View commit details
    Browse the repository at this point in the history

  2. Ignore previously received commit_sig 

    When expecting a retransmission of `tx_signatures`, we should ignore the
`commit_sig` they send just before if we've already received it. The right
way to check that we've already received it is to compare its signature
to our latest commitment transaction.
    @t-bast
    t-bast committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    49a6b11 View commit details
    Browse the repository at this point in the history

  3. Fix PR comments

    @t-bast
    t-bast committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4f2e481 View commit details
    Browse the repository at this point in the history