Correctly extract pubkeyScript from witness data
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When publishing delayed txes, we need to first watch the parent transaction in order to know how many confirmations it has. Electrum relies on hashes of `pubkeyScript`s in order to track transactions. In order to do this without having the parent transaction at hand, we recompute the `pubkeyScript` from the child transaction witness data and give it to Electrum. But if the script was a `pay2wsh`, we were using the `redeemScript` instead of computing the `pubkeyScript`.
sstone
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing delayed txes, we need to first watch the parent
transaction in order to know how many confirmations it has.
Electrum relies on hashes of
pubkeyScripts in order to tracktransactions.
In order to do this without having the parent transaction at hand,
we recompute the
pubkeyScriptfrom the child transaction witness dataand give it to Electrum.
But if the script was a
pay2wsh, we were using theredeemScriptinstead of computing the
pubkeyScript.This is the root cause of ACINQ/eclair-mobile#17.