Electrum fixes #873
Merged
Electrum fixes #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sstone
commented
Feb 18, 2019
sstone
commented
- clear history status when we get disconnected and still have pending history requests
- represent block heights as signed integers
- prepend a version number to persisted electrum wallet data
…g history transactions When we get disconnected and have script hashes for which we still have pending connections, clear the script hash status. When we reconnect we will ask for its history again, this way we won't miss anything. Since we rotate keys it should not result in heavy traffic (script hashes have few history items).
Int.MaxValue is about 40,000 years of block which should be enough, and it will fix the encoding problem users on testnet when there's a reorg and one of their txs has a height of -1. Side-note: changing the wallet codec can be done easily: if we cannot read and decode persisted data we just start with an empty wallet and retrieve all wallet data from electrum servers, and once it's ready it will be encoded with the new codec and saved.
It provides a clean way, when upgrading the app, of choosing whether to keep the same version and start from the last persisted wallet (if the persistence format has not been changed or is compatible with the old one), or to change the version and force starting from an empty wallet and downloading all wallet items from Electrum servers.
pm47
reviewed
Feb 18, 2019
| downloadHeadersIfMissing(height.toInt) | ||
| client ! GetMerkle(txid, height.toInt) | ||
| case (Some(previousHeight), height) if previousHeight == height && data.proofs.get(txid).isEmpty => | ||
| if (height > 0) { |
There was a problem hiding this comment.
Why isn't this check in the downloadHeadersIfMissing function?
There was a problem hiding this comment.
Because you don't want to download headers, but you also don't want to download merkle proofs.
pm47
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.