Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some features still need regression tests #52

Open
5 of 21 tasks
bprather opened this issue Dec 8, 2023 · 1 comment
Open
5 of 21 tasks

Some features still need regression tests #52

bprather opened this issue Dec 8, 2023 · 1 comment

Comments

@bprather
Copy link
Contributor

bprather commented Dec 8, 2023 •
edited
Loading

Masterlist of things I've said "that needs a test" about

  • Multizone regression test, e.g. match a magnetized Bondi solution after a few iterations
  • Restart w/EMHD enabled
  • Restart w/Electrons enabled
  • Restart w/Face-CT enabled
  • Restart w/SMR enabled
  • SMR modes convergence
  • SMR keeps divB with wacky O-T vortex meshblock breakdown
  • SMR keeps divB in small 3D torus problem
  • SMR convergence on more tests, e.g. Bondi
  • Re-enable all electrons tests not currently run w/CI, with real failure criteria
  • Komissarov blast with outflow boundary conditions
  • Spherical grid with outflow conditions, outflowing/polar blob
  • Mid-MAD test for continued agreement with iharm3d in that mode
  • Hubble flow. Implemented but has a bug in the source/boundary
  • 2D driven turbulence for e- heating
  • "Shadow" test of relative e- entropy in a full 2D SANE model
  • Field loop advection in Cartesian
  • Field loop advection across pole
  • MHD modes across pole
  • P->U->P direct inverter tests
  • Tests that reductions are calculated correctly by checking history file
@bprather bprather mentioned this issue Jan 3, 2024
Merged
5 tasks
@bprather bprather mentioned this issue Jan 18, 2024
Merged
5 tasks
@vedantdhruv96
Copy link
Contributor

@samason4 has recently implemented restart with electrons and I believe he has tested it. He could open a PR to dev.

@bprather bprather changed the title Some new functionality needs tests Some features still need regression tests Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bprather @vedantdhruv96