Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyo3 requirement from 0.18 to 0.21 #2229

Closed
wants to merge 4 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 20, 2024

Updates the requirements on pyo3 to permit the latest version.

Release notes

Sourced from pyo3's releases.

PyO3 0.18.3

This release fixes an issue with PyDateTime::type_object() incorrectly returning the type object for PyDate, which would cause some is_instance checks to behave incorrectly.

In addition, this release contains a handful of minor quality-of-life corrections over PyO3 0.18.2.

Thank you to the following users for the improvements:

@​adamreichold @​davidhewitt @​decathorpe @​ijl @​mejrs @​messense @​sollyucko @​willstott101 @​wjones127

Changelog

Sourced from pyo3's changelog.

[0.18.3] - 2023-04-13

Added

  • Add GILProtected<T> to mediate concurrent access to a value using Python's global interpreter lock (GIL). #2975
  • Support PyASCIIObject / PyUnicode and associated methods on big-endian architectures. #3015
  • Add FFI definition _PyDict_Contains_KnownHash() for CPython 3.10 and up. #3088

Fixed

  • Fix compile error for #[pymethods] and #[pyfunction] called "output". #3022
  • Fix compile error in generated code for magic methods implemented as a #[staticmethod]. #3055
  • Fix is_instance for PyDateTime (would incorrectly check for a PyDate). #3071
  • Fix upstream deprecation of PyUnicode_InternImmortal since Python 3.10. #3071

[0.18.2] - 2023-03-24

Packaging

  • Disable default features of chrono to avoid depending on time v0.1.x. #2939

Added

  • Implement IntoPy<PyObject>, ToPyObject and FromPyObject for Cow<[u8]> to efficiently handle both bytes and bytearray objects. #2899
  • Implement IntoPy<PyObject>, ToPyObject and FromPyObject for Cell<T>. #3014
  • Add PyList::to_tuple(), as a convenient and efficient conversion from lists to tuples. #3042
  • Add PyTuple::to_list(), as a convenient and efficient conversion from tuples to lists. #3044

Changed

  • Optimize PySequence conversion for list and tuple inputs. #2944
  • Improve exception raised when creating #[pyclass] type object fails during module import. #2947
  • Optimize PyMapping conversion for dict inputs. #2954
  • Allow create_exception! to take a dotted.module to place the exception in a submodule. #2979

Fixed

  • Fix a reference counting race condition affecting PyObjects cloned in allow_threads blocks. #2952
  • Fix clippy::redundant_closure lint on default arguments in #[pyo3(signature = (...))] annotations. #2990
  • Fix non_snake_case lint on generated code in #[pyfunction] macro. #2993
  • Fix some FFI definitions for the upcoming PyPy 3.10 release. #3031

[0.18.1] - 2023-02-07

Added

  • Add PyErr::write_unraisable(). #2889
  • Add Python::Ellipsis() and PyAny::is_ellipsis() methods. #2911

... (truncated)

Commits
  • 5cdc133 release: 0.18.3
  • a8dd453 PEP 623: wstr, wstr_length, state changes
  • 9ebdcb7 Define _PyDict_Contains_KnownHash() FFI for CPython 3.10 or later
  • 7cc2644 Fix redundant imports in doc tests thereby fixing the careful CI job.
  • 8498003 docs: show pattern for self.class.name in repr
  • 63ff262 fix typo DateType -> DateTimeType, fixes #3069
  • 48c0655 Add wrapper for PyASCIIObject state bitfield accesses based on bindgen
  • ce288e6 CI: Pin inventory to 0.3.4 in MSRV job
  • 9dccad3 Emit a better error for bad argument names
  • 24d2ddd Fix function name shadowing
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 20, 2024
@domenukk
Copy link
Member

@rmalmain I guess this lacks the same changes on the qemu bridge side

@domenukk domenukk marked this pull request as draft May 20, 2024 14:53
@rmalmain
Copy link
Collaborator

@domenukk I tried to update this dependency in the past, but this update is not possible because of this dependency. If we want the update to work, we need this crate to be up to date as well. Should I open a PR there?

@dependabot dependabot bot force-pushed the dependabot/cargo/pyo3-0.21 branch from 64f4644 to bea0cfb Compare May 28, 2024 09:40
@domenukk
Copy link
Member

This needs changes in nautilus - cc @eqv

Updates the requirements on [pyo3](https://github.com/pyo3/pyo3) to permit the latest version.
- [Release notes](https://github.com/pyo3/pyo3/releases)
- [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md)
- [Commits](PyO3/pyo3@v0.18.0...v0.18.3)

---
updated-dependencies:
- dependency-name: pyo3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@domenukk
Copy link
Member

domenukk commented Jun 3, 2024

@domenukk I tried to update this dependency in the past, but this update is not possible because of this dependency. If we want the update to work, we need this crate to be up to date as well. Should I open a PR there?

@rmalmain we got rid of the dependency / included it in the repo now, can you see if we can update pyo3 now?

@rmalmain
Copy link
Collaborator

rmalmain commented Jun 3, 2024

It should be good to go now

@domenukk domenukk marked this pull request as ready for review July 2, 2024 17:11
@domenukk
Copy link
Member

Closed in favor of #2459

@domenukk domenukk closed this Jul 29, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 29, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/pyo3-0.21 branch July 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants