Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

LinkedIn OAuth1.0a fails #17

Closed
pj4533 opened this Issue Jan 30, 2013 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

pj4533 commented Jan 30, 2013

Two problems:

  • Content-Type needs to be text/xml. Probably nothing to be done here, since this seems very LinkedIn-only-ish.
  • "Properly handling oauth_token_secret" - Apparently 'Twitter is particularly lenient with the use of oauth_token_secret' (http://developer.linkedin.com/documents/common-issues-oauth-authentication). Maybe this deserves a pull-request update in AFOAuth1Client?

I made a subclass that works here: https://github.com/pj4533/AFLinkedInOAuth1Client

Interested to hear your thoughts. I'll make a pull request, if you think necessary.

mattt added a commit that referenced this issue Mar 5, 2013

[Issue #17] Setting accessToken to requestToken in -acquireOAuthAcces…
…sTokenWithPath:requestToken:accessMethod:success:failure:
Contributor

mattt commented Mar 5, 2013

I don't think there's anything to be done about the text/xml content type. That's an unfortunate quirk of LinkedIn's system.

With regards to the lenient oath_token_secret, feel free to send a pull request if that's something you think is necessary. I didn't see anything about that specifically in your extension, so I'm assuming that it's not a deal breaker.

As for the other aspects of what your subclass does, f285886 should obviate the need to override -acquireOAuthAccessTokenWithPath:... as you do. I'm not sure why that was the way it was.

@mattt mattt closed this Mar 5, 2013

mattt added a commit that referenced this issue Mar 5, 2013

Revert "[Issue #17] Setting accessToken to requestToken in -acquireOA…
…uthAccessTokenWithPath:requestToken:accessMethod:success:failure:"

This reverts commit f285886.

mattt added a commit that referenced this issue Mar 5, 2013

Revert "Revert "[Issue #17] Setting accessToken to requestToken in -a…
…cquireOAuthAccessTokenWithPath:requestToken:accessMethod:success:failure:""

This reverts commit 9b2fb31.
Contributor

seivan commented Mar 19, 2013

So what's the state here? I can't use normal AFOAuth1Client to login with linked in.
signature_invalid

Contributor

pj4533 commented Mar 19, 2013

You can checkout my subclass: https://github.com/pj4533/AFLinkedInOAuth1Client

Also, make sure to read this: #24

Contributor

seivan commented Mar 19, 2013

Yup, using your pod now, thanks a lot, appreciate it.

On Mar 19, 2013, at 10:45 PM, PJ Gray <notifications@github.commailto:notifications@github.com> wrote:

You can checkout my subclass: https://github.com/pj4533/AFLinkedInOAuth1Client

Also, make sure to read this: #24#24


Reply to this email directly or view it on GitHubhttps://github.com/AFNetworking/AFOAuth1Client/issues/17#issuecomment-15145303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment