Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

LinkedIn OAuth1.0a fails #17

Closed
pj4533 opened this Issue · 4 comments

3 participants

@pj4533

Two problems:

  • Content-Type needs to be text/xml. Probably nothing to be done here, since this seems very LinkedIn-only-ish.

  • "Properly handling oauth_token_secret" - Apparently 'Twitter is particularly lenient with the use of oauth_token_secret' (http://developer.linkedin.com/documents/common-issues-oauth-authentication). Maybe this deserves a pull-request update in AFOAuth1Client?

I made a subclass that works here: https://github.com/pj4533/AFLinkedInOAuth1Client

Interested to hear your thoughts. I'll make a pull request, if you think necessary.

@mattt mattt referenced this issue from a commit
@mattt mattt [Issue #17] Setting accessToken to requestToken in -acquireOAuthAcces…
…sTokenWithPath:requestToken:accessMethod:success:failure:
f285886
@mattt
Owner

I don't think there's anything to be done about the text/xml content type. That's an unfortunate quirk of LinkedIn's system.

With regards to the lenient oath_token_secret, feel free to send a pull request if that's something you think is necessary. I didn't see anything about that specifically in your extension, so I'm assuming that it's not a deal breaker.

As for the other aspects of what your subclass does, f285886 should obviate the need to override -acquireOAuthAccessTokenWithPath:... as you do. I'm not sure why that was the way it was.

@mattt mattt closed this
@mattt mattt referenced this issue from a commit
@mattt mattt Revert "[Issue #17] Setting accessToken to requestToken in -acquireOA…
…uthAccessTokenWithPath:requestToken:accessMethod:success:failure:"

This reverts commit f285886.
9b2fb31
@mattt mattt referenced this issue from a commit
@mattt mattt Revert "Revert "[Issue #17] Setting accessToken to requestToken in -a…
…cquireOAuthAccessTokenWithPath:requestToken:accessMethod:success:failure:""

This reverts commit 9b2fb31.
7c58105
@seivan

So what's the state here? I can't use normal AFOAuth1Client to login with linked in.
signature_invalid

@pj4533

You can checkout my subclass: https://github.com/pj4533/AFLinkedInOAuth1Client

Also, make sure to read this: #24

@seivan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.