Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iceberg renderer crashes with Sodium 0.4.9 when displaying tooltips with Legendary Tooltips installed #21

Closed
Timolino456 opened this issue Feb 7, 2023 · 8 comments

Comments

@Timolino456
Copy link

See CaffeineMC/sodium#1602, the crash report attached there and JellySquids comment. I can't really add anything else but I wanted to let you know of the issue.

@ydoc5212
Copy link

ydoc5212 commented Feb 9, 2023

Same issue! helpful thread, thanks! Will uninstall iceberg and legendary tooltips for now :P

@AHilyard
Copy link
Owner

AHilyard commented Feb 9, 2023

Thanks for creating this, I've received a lot of reports about it recently. I've determined the cause of the crash and prepared a fix for it, however version 0.4.10 of Sodium will be coming out soon(ish?) which will break my fix. I am going to hold off on releasing an updated Iceberg build with a fix until Sodium releases version 0.4.10 because of this.
In the meantime, you can either downgrade Sodium to version 0.4.8 or disable 3D item previews in Legendary Tooltips if you want to continue using both mods.

@EGOIST1372
Copy link

IDK it's the same issue or not but here is the bug report
---- Minecraft Crash Report ----
// My bad.

Time: 2023-02-10 22:11:03
Description: Rendering item

java.lang.ClassCastException

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Render thread
Stacktrace:
at com.anthonyhilyard.iceberg.renderer.CustomItemRenderer.renderDetailModelIntoGUI(CustomItemRenderer.java:620)
Mixins in Stacktrace: None found

-- Item being rendered --
Details:
Item Type: netherite_sword
Registry Name: minecraft:netherite_sword
Item Damage: 133
Item NBT: {Damage:133,Enchantments:[{id:"minecraft:sharpness",lvl:5s}],RepairCost:1,display:{Name:'{"text":"emerald sword"}'}}
Item Foil: true
Stacktrace:
at com.anthonyhilyard.iceberg.renderer.CustomItemRenderer.renderDetailModelIntoGUI(CustomItemRenderer.java:620)
at com.anthonyhilyard.legendarytooltips.tooltip.ItemModelComponent.method_32666(ItemModelComponent.java:95)
at net.minecraft.class_437.redirect$ehp000$drawPosAwareComponent(class_437.java:12258)
at net.minecraft.class_437.method_32633(class_437.java:283)
at net.minecraft.class_437.method_32634(class_437.java:193)
at net.minecraft.class_481.method_25409(class_481.java:779)
at net.minecraft.class_465.method_2380(class_465.java:188)
at net.minecraft.class_481.method_25394(class_481.java:745)
at net.minecraft.class_437.method_47413(class_437.java:113)
at net.minecraft.class_757.method_3192(class_757.java:929)
at net.minecraft.class_310.method_1523(class_310.java:1193)
at net.minecraft.class_310.method_1514(class_310.java:781)
at net.minecraft.client.main.Main.method_44604(Main.java:244)
at net.minecraft.client.main.Main.main(Main.java:51)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Mixins in Stacktrace: None found

-- Screen render details --
Details:
Screen name: net.minecraft.class_481
Mouse location: Scaled: (311, 191). Absolute: (2495.000000, 1528.000000)
Screen size: Scaled: (480, 270). Absolute: (3840, 2160). Scale factor of 8.000000

@AHilyard
Copy link
Owner

Yes, this is the same issue.

@exultiaa
Copy link

In the meantime, you can either downgrade Sodium to version 0.4.8 or disable 3D item previews in Legendary Tooltips if you want to continue using both mods.

how would one disable 3D item previews? i could just have missed it entirely, but i didn't see an option for it in the config.

@AHilyard
Copy link
Owner

In the meantime, you can either downgrade Sodium to version 0.4.8 or disable 3D item previews in Legendary Tooltips if you want to continue using both mods.

how would one disable 3D item previews? i could just have missed it entirely, but i didn't see an option for it in the config.

Set the render_item_model option to "NONE".

@exultiaa
Copy link

ahh, okay sorry. thank you!

@AHilyard
Copy link
Owner

Sorry for the delay everyone, this issue has been fixed in Iceberg version 1.1.5, which you can find here: https://www.curseforge.com/minecraft/mc-mods/iceberg-fabric/files/44654276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants