Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Obslytics OCP4 Migration Overlay #109

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Add Obslytics OCP4 Migration Overlay #109

merged 1 commit into from
Oct 15, 2021

Conversation

gmfrasca
Copy link
Member

  • Similar to prod but suspends the ETL pipeline Cron triggers
  • Verification CronWorkflow is, however, enabled
  • IDH-161

@gmfrasca
Add Obslytics OCP4 Migration Overlay
03f5540 
- Similar to prod but suspends the ETL pipeline Cron triggers
- Verification CronWorkflow is, however, enabled
- IDH-161
@todo
Copy link

todo bot commented Oct 11, 2021

remove once ready to migrate

internal-data-hub/obslytics/overlays/ocp4-migration/backfill-cron-workflow.yaml

Line 12 in 03f5540

value: true # TODO: remove once ready to migrate

This comment was generated by todo based on a TODO comment in 03f5540 in #109. cc @gmfrasca.

@todo
Copy link

todo bot commented Oct 11, 2021

remove once ready to migrate

internal-data-hub/obslytics/overlays/ocp4-migration/obslytics-cron-workflow.yaml

Line 12 in 03f5540

value: true # TODO: remove once ready to migrate

This comment was generated by todo based on a TODO comment in 03f5540 in #109. cc @gmfrasca.

@todo
Copy link

todo bot commented Oct 11, 2021

add the following metrics to this list

internal-data-hub/obslytics/overlays/ocp4-migration/triggers.yaml

Lines 28 to 33 in 03f5540

# TODO: add the following metrics to this list
# "cluster_operator_conditions", # TODO: times out
- op: replace
path: /spec/templates/1/steps/1/0/withItems
value:
- ceph_cluster_total_bytes

This comment was generated by todo based on a TODO comment in 03f5540 in #109. cc @gmfrasca.

@todo
Copy link

todo bot commented Oct 11, 2021

times out

internal-data-hub/obslytics/overlays/ocp4-migration/triggers.yaml

Lines 29 to 34 in 03f5540

# "cluster_operator_conditions", # TODO: times out
- op: replace
path: /spec/templates/1/steps/1/0/withItems
value:
- ceph_cluster_total_bytes
- ceph_cluster_total_used_raw_bytes

This comment was generated by todo based on a TODO comment in 03f5540 in #109. cc @gmfrasca.

@todo
Copy link

todo bot commented Oct 11, 2021

add the following metrics to this list

internal-data-hub/obslytics/overlays/ocp4-migration/triggers.yaml

Lines 55 to 60 in 03f5540

# TODO: add the following metrics to this list
# - cluster_operator_conditions # TODO: times out
- op: replace
path: /spec/templates/2/steps/0/0/withItems
value:
- ceph_cluster_total_bytes

This comment was generated by todo based on a TODO comment in 03f5540 in #109. cc @gmfrasca.

@todo
Copy link

todo bot commented Oct 11, 2021

times out

internal-data-hub/obslytics/overlays/ocp4-migration/triggers.yaml

Lines 56 to 61 in 03f5540

# - cluster_operator_conditions # TODO: times out
- op: replace
path: /spec/templates/2/steps/0/0/withItems
value:
- ceph_cluster_total_bytes
- ceph_cluster_total_used_raw_bytes

This comment was generated by todo based on a TODO comment in 03f5540 in #109. cc @gmfrasca.

@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2021
@todo
Copy link

todo bot commented Oct 11, 2021

add the following metrics to this list

internal-data-hub/obslytics/overlays/ocp4-migration/triggers.yaml

Lines 82 to 83 in 03f5540

# TODO: add the following metrics to this list
# - cluster_operator_conditions # TODO: times out

This comment was generated by todo based on a TODO comment in 03f5540 in #109. cc @gmfrasca.

@todo
Copy link

todo bot commented Oct 11, 2021

times out

internal-data-hub/obslytics/overlays/ocp4-migration/triggers.yaml

Line 83 in 03f5540

# - cluster_operator_conditions # TODO: times out

This comment was generated by todo based on a TODO comment in 03f5540 in #109. cc @gmfrasca.

lucferbux
lucferbux requested changes Oct 14, 2021
View reviewed changes
obslytics/overlays/ocp4-migration/obslytics-cron-workflow.yaml

- op: add
path: /spec/suspend
value: true # TODO: remove once ready to migrate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! this (and matching operation in the backfill-cron-workflow.yaml) is actually one of the only two differences between the standard prod and ocp4-migration overlays, and thus the point of the whole review :P

The purpose of these suspends are to prevent parallel instances of the ETL pipelines, which would introduce a huge race condition.

@accorvin
Copy link
Member

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
anishasthana
anishasthana approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta
Copy link

sesheta commented Oct 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2021
@sesheta sesheta merged commit 50a34ff into AICoE:main Oct 15, 2021
@todo todo bot mentioned this pull request Oct 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucferbux lucferbux lucferbux requested changes

@anishasthana anishasthana anishasthana approved these changes

@accorvin accorvin Awaiting requested review from accorvin

Assignees

@accorvin accorvin

@anishasthana anishasthana

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmfrasca @accorvin @sesheta @anishasthana @lucferbux