Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obslytics metrics add #188

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Obslytics metrics add #188

merged 2 commits into from
Dec 3, 2021

Conversation

gmfrasca
Copy link
Member

@gmfrasca gmfrasca commented Dec 2, 2021

No description provided.

@todo
Copy link

todo bot commented Dec 2, 2021

add the following metrics to this list (currently timeout or OOMKill)

internal-data-hub/obslytics/overlays/ocp4-migration/triggers.yaml

Lines 80 to 85 in dc6b9d2

# TODO: add the following metrics to this list (currently timeout or OOMKill)
# - size: xl
# backfill_to: 2019-06-01T00:00:00Z
# name: cluster:usage:resources:sum
# - size: xl
# backfill_to: 2019-06-01T00:00:00Z

This comment was generated by todo based on a TODO comment in dc6b9d2 in #188. cc @gmfrasca.

anishasthana
anishasthana reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@accorvin
Copy link
Member

accorvin commented Dec 3, 2021

/approve

@sesheta
Copy link

sesheta commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: accorvin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021
@gmfrasca
Copy link
Member Author

gmfrasca commented Dec 3, 2021

/retest

@accorvin accorvin merged commit d0f2c7b into AICoE:main Dec 3, 2021
@todo todo bot mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishasthana anishasthana anishasthana left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmfrasca @accorvin @sesheta @anishasthana