Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

const_declaration code is not generated for components #115

Closed
tmadlener opened this issue Jul 8, 2020 · 0 comments · Fixed by #117
Closed

const_declaration code is not generated for components #115

tmadlener opened this issue Jul 8, 2020 · 0 comments · Fixed by #117

Comments

@tmadlener
Copy link
Collaborator

Extra code that is declared as const_declaration is not generated for components.

Since there really is no difference between const_declaration and declaration for components, I think it is OK to only consider the declaration for components. However, since then const_declaration is most likely a user input error, the validation should get this.

Do I miss something, that would make a differentiation between const_declaration and declaration necessary for components?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code generator refactoring tmadlener/podio
1 participant
@tmadlener