Fix 1931 #1943
Closed
Fix 1931 #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +50,8 @@ | |||
| from safe.utilities.resources import resources_path, get_ui_class | |||
| from safe.messaging import styles | |||
| from safe.gui.tools.minimum_needs.needs_profile import NeedsProfile | |||
| import logging | |||
| LOGGER = logging.getLogger('InaSAFE') | |||
There was a problem hiding this comment.
Maybe you should leave this out of production code.
|
Hi @Jannes123, have a look at my comments. I would expect that the user might save and save as, in which cases the note should be removed. Also please add same tests to follow the new logic flow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the fix for issue #1931
@cchristelis please review