Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retry-After HTTP header [optional] to HTTP 503 & 413 responses #67

Open
AKlaus opened this issue Nov 5, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@AKlaus
Copy link
Owner

AKlaus commented Nov 5, 2023

Following up #45 and #63 issues, the devs might want to return a value in the Retry-After header.
As per the specs on 413 and 503 HTTP codes:

This response should be used for temporary conditions and the Retry-After HTTP header should, if possible, contain the estimated time for the recovery of the service.

To get it done, the implementation should include:

  1. An optional int parameter (to indicate the waiting period) to IDomainResult in methods ContentTooLarge() and CriticalDependencyError().
  2. Handle the field in conversions in DomainResultExtensions and DomainResultExtensions in DomainResults.Mvc project.

This would require breaking changes to IDomainResultBase interface to store the Retry-After, which might add unnecessary complexity which will be consumed just by a handful of devs.

@AKlaus AKlaus added the enhancement New feature or request label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant