Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing CPU time reset #1814

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix missing CPU time reset #1814

merged 1 commit into from
Jul 5, 2022

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 30, 2022

Fixes incorrect CPU times reported if a Solver instance is used for multiple simulations. (So far, the cumulative CPU time would have been reported).

Fixes #1812

Fixes incorrect CPU times reported if a Solver instance is used for multiple simulations.

Fixes #1812
@dweindl dweindl requested a review from FFroehlich June 30, 2022 09:23
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1814 (d6faf31) into develop (e835f94) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1814      +/-   ##
===========================================
- Coverage    76.11%   76.08%   -0.04%     
===========================================
  Files           74       74              
  Lines        12647    12655       +8     
===========================================
+ Hits          9626     9628       +2     
- Misses        3021     3027       +6     
Flag Coverage Δ
cpp 72.72% <100.00%> (-0.05%) ⬇️
petab 59.48% <ø> (ø)
python 68.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/amici.cpp 71.73% <100.00%> (+1.28%) ⬆️
src/solver.cpp 76.32% <100.00%> (+0.05%) ⬆️
src/spline.cpp 65.59% <0.00%> (-6.46%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 6daf2d4 into develop Jul 5, 2022
@dweindl dweindl deleted the fix_1812_time_reset branch July 5, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants