Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subselection of state variables for steady-state simulations #2387

Merged
merged 6 commits into from Apr 20, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 26, 2024

Allow subselection of state variables for convergence check during steady-state simulations via Model.set_steadystate_mask([1, 0, ..., 1]) (positve value: check; non-positive: don't check).

Closes #2368

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 77.62%. Comparing base (e8493cf) to head (137af9d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2387   +/-   ##
========================================
  Coverage    77.61%   77.62%           
========================================
  Files          324      324           
  Lines        20895    20925   +30     
  Branches      1458     1464    +6     
========================================
+ Hits         16218    16243   +25     
- Misses        4674     4679    +5     
  Partials         3        3           
Flag Coverage Δ
cpp 73.40% <82.35%> (+0.01%) ⬆️
cpp_python 34.16% <17.64%> (-0.04%) ⬇️
petab 36.74% <21.21%> (-0.04%) ⬇️
python 72.16% <70.58%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/amici/model.h 78.26% <100.00%> (+4.57%) ⬆️
include/amici/serialization.h 96.80% <100.00%> (+0.01%) ⬆️
include/amici/steadystateproblem.h 100.00% <ø> (ø)
include/amici/vector.h 83.33% <ø> (ø)
python/sdist/amici/swig_wrappers.py 92.94% <ø> (ø)
src/steadystateproblem.cpp 83.92% <100.00%> (+0.36%) ⬆️
src/hdf5.cpp 89.60% <25.00%> (-0.39%) ⬇️
src/model.cpp 83.94% <75.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

@dweindl dweindl self-assigned this Mar 26, 2024
@dweindl dweindl marked this pull request as ready for review April 17, 2024 17:50
@dweindl dweindl requested a review from a team as a code owner April 17, 2024 17:50
@dweindl dweindl enabled auto-merge April 20, 2024 06:02
@dweindl dweindl mentioned this pull request Apr 20, 2024
@dweindl dweindl added this pull request to the merge queue Apr 20, 2024
Merged via the queue into AMICI-dev:develop with commit 01cc4e9 Apr 20, 2024
20 checks passed
@dweindl dweindl deleted the ft_2368_partial_equilibration branch April 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants