Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.24.0 #2406

Merged
merged 17 commits into from
Apr 22, 2024
Merged

Release 0.24.0 #2406

merged 17 commits into from
Apr 22, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 20, 2024

This will be the last release supporting Python 3.9 (#2391)

dweindl and others added 14 commits March 13, 2024 17:59
)

If some `ExpData` is provided, `plot_observable_trajectories` will now also visualize the measurements.
* Ensure initial state parameters are always fixed parameters
* Ensure initial concentration for preequilibration and simulation are both set in both phases to avoid NaN issues
* Fix initialAssignment handling during PEtab import (missed in #2359)
Fixes cmake-install failures during model import in cases where BLAS was not found via FindBLAS.

Needs a prettier solution at some point, but it does the job for now.
A few recently added members were missing. Constraints were not copied when cloning a Solver.
* Update valgrind suppressions
Removes the check for non-finite timepoints. This rather confusing (#2370) than helpful.
The current timepoint is already included in all other nan/inf messages, and the other
timepoints don't matter in this context.

Closes #2370.
#2401)

…annotations

Should cover everything currently present in `amici.py`, except for overloaded methods.

Exclude two methods from swig interface that aren't easily usable from Python.
`import exhale_multiproject_monkeypatch` fails on some systems due to unclear sys.path issues.
Therefore, we need to adjust sys.path manually.
So far, only the explicitly listed attributes are accessible directly via SwigPtrView.
Things like ReturnData.ny are only available through ReturnDataView.ptr.ny, which is inconvenient.
Let's just look all non-private attributes that are not already explicitly handled by SwigPtrView
on _swigptr and return them as is.
So far, CMakeLists.txt only provided a path hint for sundials for the
standalone c++ library, but not for the python package. The latter
should be added to ensure the right sundials version is found. There
have been issues with system installations of sundials.

Closes #2394
@dweindl dweindl requested a review from a team as a code owner April 20, 2024 06:28
@dweindl dweindl self-assigned this Apr 20, 2024
…2387)

* Allow subselection of state variables for steady-state simulations

Closes #2368

* ..
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 32.35294% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 77.82%. Comparing base (4d40911) to head (9894987).

❗ Current head 9894987 differs from pull request most recent head ca9d467. Consider uploading reports for the commit ca9d467 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2406      +/-   ##
==========================================
+ Coverage   77.73%   77.82%   +0.09%     
==========================================
  Files         324      324              
  Lines       20864    20895      +31     
  Branches     1458     1458              
==========================================
+ Hits        16219    16262      +43     
+ Misses       4642     4630      -12     
  Partials        3        3              
Flag Coverage Δ
cpp 76.21% <23.52%> (+2.70%) ⬆️
cpp_python 34.19% <14.70%> (-0.04%) ⬇️
petab 36.78% <23.52%> (-0.04%) ⬇️
python 72.37% <22.05%> (+0.08%) ⬆️
sbmlsuite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
python/sdist/amici/numpy.py 87.61% <100.00%> (ø)
python/sdist/amici/petab/parameter_mapping.py 81.05% <100.00%> (+0.30%) ⬆️
python/sdist/amici/petab/sbml_import.py 54.92% <100.00%> (ø)
src/amici.cpp 81.41% <ø> (ø)
src/model.cpp 84.02% <ø> (-0.16%) ⬇️
src/solver.cpp 75.79% <100.00%> (+0.08%) ⬆️
src/solver_idas.cpp 37.69% <0.00%> (ø)
python/sdist/amici/plotting.py 0.00% <0.00%> (ø)
python/sdist/amici/swig.py 12.50% <15.62%> (+1.97%) ⬆️

... and 3 files with indirect coverage changes

* KissVen2024

* ..
@dweindl dweindl merged commit 29b7ee8 into master Apr 22, 2024
43 of 45 checks passed
@dweindl dweindl deleted the release_0.24.0 branch April 22, 2024 07:53
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants