Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VODE/VODE90 has extra copy of Jacobian #216

Closed
zingale opened this issue Nov 19, 2019 · 1 comment
Closed

VODE/VODE90 has extra copy of Jacobian #216

zingale opened this issue Nov 19, 2019 · 1 comment

Comments

@zingale
Copy link
Member

zingale commented Nov 19, 2019

In VODE/VODE90, the integrator stores the Jacobian internally as an array, but we also create a burn_t that has a copy of the Jacobian for calling the network stuff. This means that we have 2 copies of the Jacobian sitting around. In BS, we don't, since the BS integrator just uses the bs_t % burn_t % jac version of the Jacobian.

We should eliminate the extra copy either by:

  • restructuring VODE's guts to work on the burn_t version
  • allowing the burn_t to have a pointer to the Jacobian, which points to VODE's version.

this may be related to #78

@zingale
Copy link
Member Author

zingale commented Jan 4, 2020

this was addressed in #220

@zingale zingale closed this as completed Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant