Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDC integrators don't support nspec_evolve != nspec #22

Closed
zingale opened this issue Nov 20, 2016 · 2 comments
Closed

SDC integrators don't support nspec_evolve != nspec #22

zingale opened this issue Nov 20, 2016 · 2 comments

Comments

@zingale
Copy link
Member

zingale commented Nov 20, 2016

The SDC integrators don't currently handle how we update species where nspec_evolve < nspec. Siince these still have advective terms, we still would need to do some integration. But the current update_unevolved_species mechanism probably is not enough

@dwillcox
Copy link
Member

dwillcox commented Dec 5, 2019

Ah, this would explain the issue @ajnonaka reported here - AMReX-Astro/MAESTROeX#124

When we update_unevolved_species we are still "evolving" those species, just analytically using the other species values.

We could fix this by:

  • write a subroutine unevolved_rhs that returns the analytic RHS for the unevolved species by differentiating the analytic update equation in update_unevolved_species and writing it in terms of the RHS for the evolved species.

  • add ifdefs for simplified SDC to network_rhs to call unevolved_rhs in addition to actual_rhs

  • add analytic RHS for unevolved species to their advective source terms to get their SDC RHS

@zingale
Copy link
Member Author

zingale commented Mar 27, 2020

we've eliminated nspec_evolve

@zingale zingale closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants