Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Simplify App Checkout #3365

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jun 13, 2023

Summary

Based on API in actions/checkout:
https://github.com/actions/checkout

Additional background

Follow-up to #3348

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l added the test label Jun 13, 2023
@ax3l ax3l requested a review from WeiqunZhang June 13, 2023 20:51
@WeiqunZhang
Copy link
Member

Sure we can use checkout action. But this CI was intended to test the latest release of amrex apps not the latest development branch. So we still need to get the latest tag. Then we could use

    # The branch, tag or SHA to checkout. When checking out the repository that
    # triggered a workflow, this defaults to the reference or SHA for that event.
    # Otherwise, uses the default branch.
    ref: ''

It does not look like there is an easy way to get the latest relase tag. So we may still need to do something like

tag=$(wget https://github.com/AMReX-Astro/Castro/releases/latest 2>&1 | grep Location: | awk '{print $2}' | awk -F/ '{print $NF}')

@WeiqunZhang WeiqunZhang enabled auto-merge (squash) June 14, 2023 21:09
@WeiqunZhang WeiqunZhang merged commit 9c41297 into AMReX-Codes:development Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants