Add AMReX Apps to CI #3348
Merged
Add AMReX Apps to CI #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Castro and WarpX are added in this commit. We can add more in the future.
zingale
approved these changes
Jun 6, 2023
|
this looks good to me |
ax3l
reviewed
Jun 13, 2023
Comment on lines
+70
to
+76
| - name: Download App | ||
| run: | | ||
| tag=$(wget https://github.com/ECP-WarpX/WarpX/releases/latest 2>&1 | grep Location: | awk '{print $2}' | awk -F/ '{print $NF}') | ||
| wget -q https://github.com/ECP-WarpX/WarpX/archive/refs/tags/${tag}.tar.gz | ||
| tar xvfz ${tag}.tar.gz | ||
| rm ${tag}.tar.gz | ||
| ln -s WarpX-${tag} WarpX |
There was a problem hiding this comment.
@WeiqunZhang you can do this:
- uses: actions/checkout@v3
repository: 'ECP-WarpX/WarpX'
path: 'WarpX'I'll send a PR :)
WeiqunZhang
added a commit
that referenced
this pull request
Jun 14, 2023
## Summary Based on API in `actions/checkout`: https://github.com/actions/checkout ## Additional background Follow-up to #3348 Co-authored-by: Weiqun Zhang <weiqunzhang@lbl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Castro and WarpX are added in this commit. We can add more in the future.
This provides more coverage. The issues in #3342 could have been avoided.