New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LoadFromBag assumptions causing C++ exceptions during serialization #438
base: rolling
Are you sure you want to change the base?
Fix LoadFromBag assumptions causing C++ exceptions during serialization #438
Conversation
* Not all bags have only GridMap messages * Not all bags have GridMap on the right topic * Add test for trying to load a grid map from a bag that doesn't contain it on the expected topic * Add nullptr check on reader messages Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
978e073
to
44cda3b
Compare
Hello @afrixs, can I get a review and approval is this solves your issue? |
Hello @Ryanf55, thank you for looking into this! I'll review and test it on Monday |
Thanks. If you have any bag files you can share to reproduce your failure, it would be much appreciated. I could cut them down and add a specific test for it. |
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Hello,
Also, there are still some linting/uncrustify errors to fix in your code
|
Description
Demo
Details
I uploaded a super small bagfile of two chatter topics. It's very small:
It might be better to construct the bag file on the fly in the test case, but that would take much more time than what I did here.
Issue
Solves #401