Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to define title format #392

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Conversation

d-koppenhagen
Copy link
Contributor

closes #376

@Morl99
Copy link

Morl99 commented Jun 20, 2023

Hello all, chiming in to let you know, that I have reviewed the change and tested it in our environment, looks good to me, and thanks @d-koppenhagen for the PR!

Copy link
Contributor

@srotsch srotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution. I have one short question, it would be cool if you could have a look. Besides that, we have already successfully tested the changes :-)

scripts/createStaticFiles.ts Outdated Show resolved Hide resolved
@srotsch srotsch merged commit dd9ce8e into AOEpeople:main Jun 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve HTML Title
3 participants