Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move styles to separate stylesheet, included via Javascript #8

Closed
nfreear opened this issue Jun 20, 2018 · 0 comments
Closed

Move styles to separate stylesheet, included via Javascript #8

nfreear opened this issue Jun 20, 2018 · 0 comments

Comments

@nfreear
Copy link

nfreear commented Jun 20, 2018

Hi @BernhardBehrendt,

As I said previously (#4), I think it would be beneficial to move the CSS styles from style HTML attributes, to a separate stylesheet.

The stylesheet would be injected/ included via Javascript.

Benefits:

  1. Easier to override styles;
  2. Possible to style on-focus and on-hover;
  3. (Possible to lint/ validate the CSS).

This involves changes to the API ... the following configuration options would no longer work:

  • buttonBgColor
  • buttonTextColor
  • noticeBgColor
  • noticeTextColor
  • linkColor

So, it will probably require a major version increment (semver).

I'll do a pull request shortly, and you can see what you think!

Yours,

Nick

nfreear added a commit to nfreear/cookie-notice that referenced this issue Jun 20, 2018
nfreear added a commit to nfreear/cookie-notice that referenced this issue Jun 20, 2018
nfreear added a commit to nfreear/cookie-notice that referenced this issue Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants