Add accessibility testing and fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… [ci skip] * Add `files`, bugs, engines & contributors fields to package JSON; * Remove Nick's email address from README & bower JSON; * Validator ~ http://package-json-validator.com/
….0 AAA * Automated accessibility testing via ~ http://pa11y.org/
* ... plus - link target, link underline
…CAG2AA * ... in the Grunt Javascript * Plus, add `live-server` to `peerDependencies` package JSON
BernhardBehrendt
approved these changes
Jun 4, 2018
There was a problem hiding this comment.
Cool to improve the cookie-notice even from an accessibility perspective too. Also like the mor modern things like rem and Changelog. Thanks again :-) @nfreear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @BernhardBehrendt,
I've added automated accessibility testing with
grunt-rsids-pa11y.There are some subtle accessibility fixes to the cookie-notice user-interface:
role=buttonattribute for the button (WAI-ARIA);linkTargetconfiguration option, so developers can settarget=_blank;Full details of the changes are in the new Changelog.
Note, these changes may be enough to justify a
1.2.0release, instead of a1.1.12(semver) -- your call!I think its important to get accessibility right, as we're providing a third-party user-interface component to developers, and saying "use this"!
(Also, I hope you don't mind - I removed my email address from the README and bower JSON.)
I hope this helps.
Best wishes,
Nick