Adds missing include and avoids unused variable #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two small issues: IAMF_decoder_private.h uses IAMF_extradata and IAMF_StreamInfo but does not include IAMF_decoder.h (And it does not appear to be transitively included, so this commit adds the include. In IAMF_decoder.c, if binauralizer is disabled, there is a unused var `ctx`. This PR moves it inside the code block where it's used to avoid that error.
|
@yilun-zhangs, @hkchung72 - this is just a small change to fix some nits building it in different environments. Can you please review. |
yilun-zhangs
approved these changes
Dec 12, 2023
jwcullen
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two small issues:
IAMF_decoder_private.h uses IAMF_extradata and IAMF_StreamInfo but does not include IAMF_decoder.h (And it does not appear to be transitively included), so this commit adds the include.
In IAMF_decoder.c, if binauralizer is disabled, there is a unused var
ctx. This PR moves it inside the code block where it's used to avoid that error.