Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #77: Update IAMF files with iacb atom and new semantics. #82

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

jwcullen
Copy link
Collaborator

  • Re-generate bitstreams after fixing bugs in the encoder, including issues where demixing parameters were applied incorrectly.
  • Drop test_000013.

  - Re-generate bitstreams after fixing bugs in the encoder, including issues where demixing parameters were applied incorrectly.
  - Drop `test_000013`.
@jwcullen
Copy link
Collaborator Author

I re-generated these using opus_encode instead of opus_encode_float which reduces the number of changed .iamf bitstreams. But since we released v1.0.0 bitstreams we have found or fixed other subtle bugs in the encoder.

For example one of these bugs was applying the incorrect demixing parameter in some circumstances. The audio frames would have been slightly off the correct results. This was not caught in conformance testing because we were doing some kind of SNR-based test and overall the audio would have been close.

I think it is better to take these changes anyway.

Choose one of this PR or #80 and then close the other without merging it in.

@jwcullen
Copy link
Collaborator Author

Accepting either of the related PRs are fine. If you already performed validation on the other one we can take it instead.

@kr728-kim
Copy link
Collaborator

Accepting either of the related PRs are fine. If you already performed validation on the other one we can take it instead.

We will perform validation on this PR

@tdaede tdaede merged commit 91d6384 into AOMediaCodec:main Feb 21, 2024
@jwcullen jwcullen deleted the issue_77_only branch June 3, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants