Skip to content
This repository has been archived by the owner on Dec 27, 2019. It is now read-only.

Several merge-backs #80

Merged
merged 10 commits into from
Apr 20, 2017
Merged

Several merge-backs #80

merged 10 commits into from
Apr 20, 2017

Conversation

liushuyu
Copy link
Contributor

@liushuyu liushuyu commented Apr 18, 2017

This change is Reviewable

@liushuyu liushuyu requested a review from LionNatsu April 18, 2017 04:26
Copy link
Contributor

@LionNatsu LionNatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to split controllers/mirrors.json to repo web-content?

@MingcongBai
Copy link
Contributor

@liushuyu

@LionNatsu
Copy link
Contributor

I am not very clear about the testing system and the new mirror status monitor... Please feel free to merge when you think it is ready to merge.

BTW, @liushuyu, it maybe too long to be an issue... I will suggest that you may separate them into several branch by their functionalities next time.

(It says: "Pull requests that have a failing status can’t be merged on a phone." 🤣)

@liushuyu
Copy link
Contributor Author

I am not very clear about the testing system and the new mirror status monitor... Please feel free to merge when you think it is ready to merge.

I was thinking it was a false-positive, but now I saw the links in RSS feed are all https://aosc.io/undefined. I'll get to fix this.

So, see, this is the use of testing system, although my tests are not very good, but still be able to figure out some problems

test: disable xml validation against rss feed: upstream bug,
`feed` does not conform to standard xsd spec
@coveralls
Copy link

coveralls commented Apr 19, 2017

Coverage Status

Changes Unknown when pulling e04147b on liushuyu:develop into on AOSC-Dev:develop.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0be707d on liushuyu:develop into ** on AOSC-Dev:develop**.

@liushuyu
Copy link
Contributor Author

Tests are passed despite the code check (need some kind of refactor to resolve the remaining problems), will merge this in 4 hours if there's no objections.

@liushuyu
Copy link
Contributor Author

will merge this in 4 minutes if there's no objections.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e40d999 on liushuyu:develop into ** on AOSC-Dev:develop**.

@Yexiaoxing
Copy link
Contributor

2 checks failed?

@liushuyu
Copy link
Contributor Author

2 checks failed?

Only one now, it's the code style issue, can't be fixed unless a refactor is done.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e40d999 on liushuyu:develop into ** on AOSC-Dev:develop**.

@liushuyu
Copy link
Contributor Author

Merged #80

@liushuyu liushuyu merged commit 75826db into AOSC-Archive:develop Apr 20, 2017
Copy link
Contributor

@LionNatsu LionNatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants