Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change twitter bird logo to 'X' logo in the footer section #207

Open
ashhcoder opened this issue Aug 13, 2024 · 10 comments
Open

change twitter bird logo to 'X' logo in the footer section #207

ashhcoder opened this issue Aug 13, 2024 · 10 comments

Comments

@ashhcoder
Copy link

ashhcoder commented Aug 13, 2024

Change the twitter bird logo to twitter 'X' logo in the footer section.
For reference:

Screenshot from 2024-08-14 01-39-09

@crazyshrut
Copy link

hey @ashhcoder can you assign this issue to me?

@Harshinireddy05
Copy link

Hey @ashhcoder I would like to work on this issue. Can you please assign this issue to me?

@ashhcoder ashhcoder changed the title change twitter bird logo to 'X' logo in the intro section change twitter bird logo to 'X' logo in the footer section Aug 13, 2024
@keshav861
Copy link

@ashhcoder the twitter logo should be replaced for the main body part too
image

@keshav861
Copy link

@ceilican i have pulled a request for the following changes of the twitter logo to "X" logo for the main body and the footer part if you think the pull request is correct kindly merge it as per your convenience.

@sankshaypusa
Copy link

HI i have changed the twitter logo and replaced it with new one,kindly check my Pull request #PR RAISED

@Vegadjay
Copy link

Vegadjay commented Aug 15, 2024

@keshav861 Is Logo changed from your approach ?

@keshav861
Copy link

@Vegadjay yes logo is changing from my approach

@Vegadjay
Copy link

@keshav861 From where you get this logo bcz this is use react-fontawsome library and that library does not contain X logo.. from where you get this logo

@keshav861
Copy link

@Vegadjay ya i got this the font awesome library doesn't support for the fontawesome V5. react-fontawesome is old library. As of now i was directly using the fontawesome official react component as in node_module i added that component so thats why i think it is working and may be it wont work on it. we have to change the react-fontawesome library to react-icons library this may solve the issue or just add add a javascript file to the html file then can use this directly these are the 2 best ways to overcome this problem i think so....

@ShivaGheji
Copy link

Hi,
I fixed the issue (#265) with the Twitter logo in the body/footer section. the new X logo wasn't available in the old version of FontAwesome, so i updated the FontAwesome packages to the latest version and replaced the logo. It's now looking good.
I've submitted a PR with the changes (#267), and i've attached a screenshot for reference. Please review it, and if everything looks good, kindly merge my PR. If there are any issues, please let me know, and I'll make the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants