Fix a possible crash in hash.c

APE-Project · May 25, 2011 · 358ea62 · 358ea62
1 parent d9d59b4
commit 358ea62
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/hash.c b/src/hash.c
@@ -93,10 +93,6 @@ void hashtbl_append(HTBL *htbl, const char *key, void *structaddr)
 	hTmp->next = NULL;
 	hTmp->lnext = htbl->first;
 	hTmp->lprev = NULL;
-
-	if (htbl->first != NULL) {
-		htbl->first->lprev = hTmp;
-	}
 
 	hTmp->key = xmalloc(sizeof(char) * (key_len+1));
 
@@ -112,6 +108,7 @@ void hashtbl_append(HTBL *htbl, const char *key, void *structaddr)
 				free(hTmp->key);
 				free(hTmp);
 				hDbl->addrs = (void *)structaddr;
+
 				return;
 			} else {
 				hDbl = hDbl->next;
@@ -120,6 +117,10 @@ void hashtbl_append(HTBL *htbl, const char *key, void *structaddr)
 		hTmp->next = htbl->table[key_hash];
 	}
 
+	if (htbl->first != NULL) {
+		htbl->first->lprev = hTmp;
+	}
+
 	htbl->first = hTmp;
 
 	htbl->table[key_hash] = hTmp;