Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): properly implement block size limit #3154

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

vasild
Copy link
Contributor

@vasild vasild commented Oct 28, 2019

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #3154 into develop will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3154      +/-   ##
===========================================
+ Coverage    65.57%   65.58%   +0.01%     
===========================================
  Files          425      425              
  Lines        11917    11925       +8     
  Branches      1637     1639       +2     
===========================================
+ Hits          7814     7821       +7     
  Misses        4067     4067              
- Partials        36       37       +1
Impacted Files Coverage Δ
packages/crypto/src/blocks/block.ts 92.59% <100%> (-0.06%) ⬇️
packages/crypto/src/blocks/serializer.ts 92% <88.88%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3877e56...1ca6b51. Read the comment docs.

@spkjp spkjp merged commit 4bbfaa2 into develop Oct 29, 2019
@ghost ghost deleted the fix-block-size-limit branch October 29, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants