-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnalogIn test issue #11746
Comments
Internal Jira reference: https://jira.arm.com/browse/MBOTRIAGE-2264 |
cc @ARMmbed/team-cypress Please review |
@0xc0170 This issue is reported by Cypress team. |
I don't understand where is the issue. What should be expected and what is failing in the init phase? can you clarify more details as you already looked at the failures. cc @ARMmbed/mbed-os-hal |
@0xc0170 I run analogin tests. main.cpp contains two test cases: Expected is to PASS 2 test cases. First passed, second failed. |
@maciejbocianski Is this similar to what you fixed in i2c - missing free function for analogin ? |
Probably because the ports are already initialized when second test case is running and re-init fails. We don't have |
@mprse Are going to add "free()" or expecting some actions from Cypress side ? |
I don't have information about adding analogin |
OK. I am goint to investigate this on Cypress side. @mprse I also see similar issue with SPI. Should I creare new issue or use this one? |
new issue would work (as its for SPI) |
This might not be a similar issue since SPI HAL API provides the |
I think we should add @0xc0170 @maciejbocianski @fkjagodzinski @kjbracey-arm @jamesbeyond what do you think? |
I thought all HAL APIs had If a HAL API doesn't have free, like this, it should be added, and we can have a weak definition for backwards compatibility to save all updating targets. The weak thing could also cope with the SPI case. Then a target needs to either cope with double init, ignoring the free, or handle init/free/init. (On the same pins). |
The following peripheral APIs do not have |
I will extend PR #11032 and add |
Same as @kjbracey-arm , also thought we already provided Thanks @mprse for fixing |
I have a question. Do you have maybe a proposition where these empty |
If only to reduce compilation time, I'd be somewhat inclined to just sneak them in to Maybe doesn't cover some test cases though. Otherwise, I'd go with something like More complex defaults (eg the pinmap stuff from #11399 in |
This might be a problem for HAL tests and might be misleading: HAL implementation in the drivers layer. |
The patch can be found in PR #11032 (comment) @yarbcy once the mentioned PR is merged you can add |
@mprse I am not clear with proposed approach. Please provide instruction what needs to be done from my side after PR is merged. |
@yarbcy The tests are failing because |
@ccli8 I found that you have added the following patch to In PR #11032 I added This might cause a regression for some Nuvoton targets and probably we will have to implement |
FYI - we are experimenting with adding priority labels to PRs based on input from partners received through partner project managers. I just added a Priority label. |
Once #11830 is in, we can close this one? |
Description of defect
FPGA test: AnalogIn test issue.
Steps to reproduce:
Target(s) affected by this defect ?
tested on CY8CKIT_062_WIFI_BT
Toolchain(s) (name and version) displaying this defect ?
tested on GCC_ARM
What version of Mbed-os are you using (tag or sha) ?
Latest
What version(s) of tools are you using. List all that apply (E.g. mbed-cli)
N/A
How is this defect reproduced ?
Always.
The text was updated successfully, but these errors were encountered: