Skip to content

/mbed-os

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Add implementations of HAL API i2c_free and analogin_free #11780

Merged
merged 3 commits into from Nov 4, 2019
Merged

Nuvoton: Add implementations of HAL API i2c_free and analogin_free #11780

merged 3 commits into from Nov 4, 2019

Conversation

@ccli8
Copy link
Contributor

ccli8 commented Oct 31, 2019 •
edited

Description (required)

Follow-up of #11746 (comment), this PR adds implementations of HAL API i2c_free(...) and analogin_free(...) for FPGA CI test shield tests on Nuvoton targets:

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487
  • NU_PFM_M2351_NPSA_NS
  • NUMAKER_IOT_M263A
  • NUMAKER_M252KG

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers

@mprse
ccli8 added 3 commits Oct 31, 2019
@ccli8
Nuvoton: Add analogin_free
3abd026 
1.  Deal with channel-wise and module-wise
2.  Disable IP clock
3.  Free up pin

Support targets:

-   NUMAKER_PFM_NANO130
-   NUMAKER_PFM_NUC472
-   NUMAKER_PFM_M453
-   NUMAKER_PFM_M487/NUMAKER_IOT_M487
-   NU_PFM_M2351*
-   NUMAKER_IOT_M263A
-   NUMAKER_M252KG
@ccli8
Nuvoton: Add i2c_free
72ea613 
1.  Disable interrupt
2.  Disable IP clock
3.  Free up pins

Support targets:

-   NUMAKER_PFM_NANO130
-   NUMAKER_PFM_NUC472
-   NUMAKER_PFM_M453
-   NUMAKER_PFM_M487/NUMAKER_IOT_M487
-   NU_PFM_M2351*
-   NUMAKER_IOT_M263A
-   NUMAKER_M252KG
@ccli8
NANO130: Remove unnecessary synchronization in analog-in HAL
Loading status checks…
0260f1b 
Driver AnalogIn has done with it, so remove synchronization in analog-in HAL.
@ccli8

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ccli8 commented Oct 31, 2019

NUMAKER_PFM_NUC472

mbedgt: test suite report:
| target                     | platform_name      | test suite                                          | result | elapsed_time (sec) | copy_method |
|----------------------------|--------------------|-----------------------------------------------------|--------|--------------------|-------------|
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-analogin | OK     | 13.96              | default     |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio     | OK     | 15.47              | default     |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio_irq | OK     | 17.11              | default     |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-i2c      | OK     | 20.58              | default     |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-pwm      | OK     | 28.76              | default     |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-spi      | OK     | 14.31              | default     |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-uart     | OK     | 16.44              | default     |
mbedgt: test suite results: 7 OK

NUMAKER_PFM_M453

mbedgt: test suite report:
| target                   | platform_name    | test suite                                          | result | elapsed_time (sec) | copy_method |
|--------------------------|------------------|-----------------------------------------------------|--------|--------------------|-------------|
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-analogin | OK     | 14.16              | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio     | OK     | 13.57              | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio_irq | OK     | 14.39              | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-i2c      | OK     | 14.31              | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-pwm      | OK     | 27.37              | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-spi      | OK     | 13.8               | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-uart     | OK     | 15.42              | default     |
mbedgt: test suite results: 7 OK

NUMAKER_PFM_M487

mbedgt: test suite report:
| target                   | platform_name    | test suite                                          | result | elapsed_time (sec) | copy_method |
|--------------------------|------------------|-----------------------------------------------------|--------|--------------------|-------------|
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-analogin | OK     | 14.26              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio     | OK     | 14.21              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio_irq | OK     | 13.41              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-i2c      | OK     | 13.6               | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-pwm      | OK     | 27.05              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-spi      | OK     | 13.75              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-uart     | OK     | 15.49              | default     |
mbedgt: test suite results: 7 OK

NUMAKER_IOT_M487

mbedgt: test suite report:
| target                   | platform_name    | test suite                                          | result | elapsed_time (sec) | copy_method |
|--------------------------|------------------|-----------------------------------------------------|--------|--------------------|-------------|
| NUMAKER_IOT_M487-GCC_ARM | NUMAKER_IOT_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-analogin | OK     | 14.15              | default     |
| NUMAKER_IOT_M487-GCC_ARM | NUMAKER_IOT_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio     | OK     | 14.59              | default     |
| NUMAKER_IOT_M487-GCC_ARM | NUMAKER_IOT_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio_irq | OK     | 15.36              | default     |
| NUMAKER_IOT_M487-GCC_ARM | NUMAKER_IOT_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-i2c      | OK     | 14.52              | default     |
| NUMAKER_IOT_M487-GCC_ARM | NUMAKER_IOT_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-pwm      | OK     | 29.83              | default     |
| NUMAKER_IOT_M487-GCC_ARM | NUMAKER_IOT_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-spi      | OK     | 13.72              | default     |
| NUMAKER_IOT_M487-GCC_ARM | NUMAKER_IOT_M487 | mbed-os-tests-mbed_hal_fpga_ci_test_shield-uart     | OK     | 15.73              | default     |
mbedgt: test suite results: 7 OK

NU_PFM_M2351_NPSA_NS

mbedgt: test suite report:
| target                       | platform_name | test suite                                          | result | elapsed_time (sec) | copy_method |
|------------------------------|---------------|-----------------------------------------------------|--------|--------------------|-------------|
| NU_PFM_M2351_NPSA_NS-GCC_ARM | NU_PFM_M2351  | mbed-os-tests-mbed_hal_fpga_ci_test_shield-analogin | OK     | 18.8               | default     |
| NU_PFM_M2351_NPSA_NS-GCC_ARM | NU_PFM_M2351  | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio     | OK     | 26.51              | default     |
| NU_PFM_M2351_NPSA_NS-GCC_ARM | NU_PFM_M2351  | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio_irq | OK     | 22.95              | default     |
| NU_PFM_M2351_NPSA_NS-GCC_ARM | NU_PFM_M2351  | mbed-os-tests-mbed_hal_fpga_ci_test_shield-i2c      | OK     | 23.66              | default     |
| NU_PFM_M2351_NPSA_NS-GCC_ARM | NU_PFM_M2351  | mbed-os-tests-mbed_hal_fpga_ci_test_shield-pwm      | OK     | 36.72              | default     |
| NU_PFM_M2351_NPSA_NS-GCC_ARM | NU_PFM_M2351  | mbed-os-tests-mbed_hal_fpga_ci_test_shield-spi      | OK     | 21.25              | default     |
| NU_PFM_M2351_NPSA_NS-GCC_ARM | NU_PFM_M2351  | mbed-os-tests-mbed_hal_fpga_ci_test_shield-uart     | OK     | 33.23              | default     |
mbedgt: test suite results: 7 OK

NUMAKER_IOT_M263A

mbedgt: test suite report:
| target                    | platform_name     | test suite                                          | result | elapsed_time (sec) | copy_method |
|---------------------------|-------------------|-----------------------------------------------------|--------|--------------------|-------------|
| NUMAKER_IOT_M263A-GCC_ARM | NUMAKER_IOT_M263A | mbed-os-tests-mbed_hal_fpga_ci_test_shield-analogin | OK     | 15.38              | default     |
| NUMAKER_IOT_M263A-GCC_ARM | NUMAKER_IOT_M263A | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio     | OK     | 15.56              | default     |
| NUMAKER_IOT_M263A-GCC_ARM | NUMAKER_IOT_M263A | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio_irq | OK     | 16.0               | default     |
| NUMAKER_IOT_M263A-GCC_ARM | NUMAKER_IOT_M263A | mbed-os-tests-mbed_hal_fpga_ci_test_shield-i2c      | OK     | 15.35              | default     |
| NUMAKER_IOT_M263A-GCC_ARM | NUMAKER_IOT_M263A | mbed-os-tests-mbed_hal_fpga_ci_test_shield-pwm      | OK     | 29.31              | default     |
| NUMAKER_IOT_M263A-GCC_ARM | NUMAKER_IOT_M263A | mbed-os-tests-mbed_hal_fpga_ci_test_shield-spi      | OK     | 15.03              | default     |
| NUMAKER_IOT_M263A-GCC_ARM | NUMAKER_IOT_M263A | mbed-os-tests-mbed_hal_fpga_ci_test_shield-uart     | OK     | 18.42              | default     |
mbedgt: test suite results: 7 OK

NUMAKER_M252KG

mbedgt: test suite report:
| target                 | platform_name  | test suite                                          | result | elapsed_time (sec) | copy_method |
|------------------------|----------------|-----------------------------------------------------|--------|--------------------|-------------|
| NUMAKER_M252KG-GCC_ARM | NUMAKER_M252KG | mbed-os-tests-mbed_hal_fpga_ci_test_shield-analogin | OK     | 12.5               | default     |
| NUMAKER_M252KG-GCC_ARM | NUMAKER_M252KG | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio     | OK     | 14.06              | default     |
| NUMAKER_M252KG-GCC_ARM | NUMAKER_M252KG | mbed-os-tests-mbed_hal_fpga_ci_test_shield-gpio_irq | OK     | 17.21              | default     |
| NUMAKER_M252KG-GCC_ARM | NUMAKER_M252KG | mbed-os-tests-mbed_hal_fpga_ci_test_shield-i2c      | OK     | 14.12              | default     |
| NUMAKER_M252KG-GCC_ARM | NUMAKER_M252KG | mbed-os-tests-mbed_hal_fpga_ci_test_shield-pwm      | OK     | 27.16              | default     |
| NUMAKER_M252KG-GCC_ARM | NUMAKER_M252KG | mbed-os-tests-mbed_hal_fpga_ci_test_shield-spi      | OK     | 13.27              | default     |
| NUMAKER_M252KG-GCC_ARM | NUMAKER_M252KG | mbed-os-tests-mbed_hal_fpga_ci_test_shield-uart     | OK     | 16.92              | default     |
mbedgt: test suite results: 7 OK
@mprse

This comment has been minimized.

Sign in to view
Copy link
Member

mprse commented Oct 31, 2019

Thanks for adding this.

Great work! Perfect test results!
@ccli8 ccli8 mentioned this pull request Oct 31, 2019
Closed
@0xc0170

This comment has been minimized.

Sign in to view
Copy link
Member

0xc0170 commented Oct 31, 2019

Great work! Perfect test results!

💯
@ciarmcom ciarmcom requested review from mprse, Ronny-Liu and ARMmbed/mbed-os-maintainers Oct 31, 2019
@ciarmcom

This comment has been minimized.

Sign in to view
Copy link
Member

ciarmcom commented Oct 31, 2019

@ccli8, thank you for your changes.
@mprse @Ronny-Liu @ARMmbed/mbed-os-maintainers please review.
@0xc0170
0xc0170 approved these changes Oct 31, 2019
View changes
@0xc0170

This comment has been minimized.

Sign in to view
Copy link
Member

0xc0170 commented Oct 31, 2019

CI started
@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 31, 2019
@mbed-ci

This comment has been minimized.

Sign in to view
Copy link

mbed-ci commented Oct 31, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Sign in to view
Copy link
Member

0xc0170 commented Oct 31, 2019

Internal fault, restart the job
@mbed-ci

This comment has been minimized.

Sign in to view
Copy link

mbed-ci commented Oct 31, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@0xc0170

This comment has been minimized.

Sign in to view
Copy link
Member

0xc0170 commented Nov 4, 2019

jenkins-ci/mbed-os-ci_cloud-client-test

It was restarted, all looks fine now
@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 4, 2019
@0xc0170 0xc0170 merged commit 5a1ccc0 into ARMmbed:master Nov 4, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8683 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170

@mprse mprse

@Ronny-Liu Ronny-Liu

Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
5 participants
@ccli8 @mprse @0xc0170 @ciarmcom @mbed-ci
You can’t perform that action at this time.